chore: format codebase with Prettier #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a CI check that the codebase is properly formatted
anton-trunov
added
infrastructure
scope: ci
novusnota
requested changes
Apr 2, 2024
byakuren-hijiri
previously approved these changes
Apr 2, 2024
There was a problem hiding this comment.
I like the idea of unified code formatting, and the default configuration suggested by Prettier looks good to me.
I would suggest only removing the following line from thepull_request_template.md, as it is checked by CI for now:
I did not introduce unrelated formatting/whitespace changes in the code base
|
@byakuren-hijiri thanks! [if only there was a way to automatically check all the other bullet points, lol] |
novusnota
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and introduce a CI check that the codebase is properly formatted
Closes #226
Everything is the default, except I kept the 4 spaces indentation level for TS and JS files (see
.editorconfig) and excluded the auto-generated and vendored files that are not in.gitignore, which Prettier ignores as well (see.prettierignore).